Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider the tree root to be "cascadable" #1120

Merged
merged 2 commits into from
May 7, 2020

Conversation

lifecrisis
Copy link
Contributor

@lifecrisis lifecrisis commented May 5, 2020

Description of Changes

Do not consider the tree root to be "cascadable"

This PR fixes an un-handled error condition. To reproduce:

  1. mkdir -p foo/bar/
  2. cd foo/
  3. vim
  4. :NERDTree
  5. Position cursor on bar/ in the NERDTree and hit x.

The result is a nasty error message because the handler for this command continues searching upward because it thinks the root isCascadable().


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merge, tag the merge commit, e.g. git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags

@PhilRunninger PhilRunninger merged commit 4cc6097 into preservim:master May 7, 2020
@lifecrisis lifecrisis deleted the fixerr branch May 7, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants