Fix the scope of several key mappings #1151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes #1149
This pull request changes the scope of some of the key mappings. Prior to this, they were scoped to run on all node types: directory and file. But they didn't make sense to be run on directory nodes, as this creates another NERDTree in the new window. The key mappings whose scopes were changed are:
i
,s
,gi
,gs
, andgo
. They now work only on file nodes and file bookmarks.When testing, it was discovered that the
go
command on directory bookmarks wasn't working correctly (probably becauseNERDTreeFind
was changed some time back). Therefore,s:previewBookmark()
was rewritten so that the bookmark directory would become the root of the NERDTree.New Version Info
Author's Instructions
MAJOR.MINOR.PATCH
version number. Increment the:MAJOR
version when you make incompatible API changesMINOR
version when you add functionality in a backwards-compatible mannerPATCH
version when you make backwards-compatible bug fixesCollaborator's Instructions
git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags