Refactor sort comparison functions, removing redundancy #1166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When researching #1162, I discovered a pair of functions that were doing very much the same thing:
Path.compareTo(path)
andnerdtree#compareNodesBySortKey(n1,n2)
. I removed thecompareTo
function, and used the more robustcompareNodesBySortKey
function instead.Speaking of
compareNodesBySortKey
, there was another function namedcompareNodes
that appeared to be unused. On the off chance that was written for other plugins, I decided to keep that function, refactored to fit the new structure.I also added a new function to accept two path objects instead of node objects. It's named
nerdtree#compareNodePaths
, and to keep things simple, it is called bynerdtree#compareNodes
.New Version Info
Author's Instructions
MAJOR.MINOR.PATCH
version number. Increment the:MAJOR
version when you make incompatible API changesMINOR
version when you add functionality in a backwards-compatible mannerPATCH
version when you make backwards-compatible bug fixesCollaborator's Instructions