Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix {'keepopen':0} in NERDTreeCustomOpenArgs #1217

Merged
merged 8 commits into from
Feb 10, 2021
Merged

Fix {'keepopen':0} in NERDTreeCustomOpenArgs #1217

merged 8 commits into from
Feb 10, 2021

Conversation

PhilRunninger
Copy link
Member

@PhilRunninger PhilRunninger commented Feb 8, 2021

Description of Changes

Closes #1168

When {'keepopen': 0} was specified in NERDTreeCustomOpenArgs the value of NERDTreeQuitOnOpen was overriding that value in the dictionary, not letting you define o to keep NERDTree open, and <CR> to close it.

This PR pushes the differentiating behavior of the NERDTreeQuitOnOpen setting up to an earlier point in the call stack, either keeping or resetting the `keepopen' value for the key mappings as appropriate.


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merging, tag the commit using these (Mac-compatible) bash commands:
    git checkout master
    git pull
    sed -n "$(grep -n -m2 '####' CHANGELOG.md | cut -f1 -d: | sed 'N;s/\n/,/')p" CHANGELOG.md | sed '$d'
    git tag -a $(read -p "Tag Name: " tag;echo $tag) -m"$(git show --quiet --pretty=%s)";git push origin --tags

@PhilRunninger PhilRunninger merged commit 593c16a into master Feb 10, 2021
@PhilRunninger PhilRunninger deleted the i1168 branch February 10, 2021 02:34
@PhilRunninger
Copy link
Member Author

This created the bug #1220.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NERDTreeCustomOpenArgs -> 'keepopen':0 not taking affect
1 participant