Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed directory separator from sort key #1219

Merged
merged 2 commits into from Feb 10, 2021
Merged

Removed directory separator from sort key #1219

merged 2 commits into from Feb 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 9, 2021

Description of Changes

Closes #1218

Directories had an additional separator appended to them which caused improper comparisons for other directories that shared similar prefixes.


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merging, tag the commit using these (Mac-compatible) bash commands:
    git checkout master
    git pull
    sed -n "$(grep -n -m2 '####' CHANGELOG.md | cut -f1 -d: | sed 'N;s/\n/,/')p" CHANGELOG.md | sed '$d'
    git tag -a $(read -p "Tag Name: " tag;echo $tag) -m"$(git show --quiet --pretty=%s)";git push origin --tags

Daniel E added 2 commits February 8, 2021 23:46
Directories had an additional separator appended to them which caused improper comparisons for other directories that shared similar prefixes.
@ghost ghost changed the title Removed path separator from directory sort key Removed directory separator from sort key Feb 9, 2021
Copy link
Member

@PhilRunninger PhilRunninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix. 👍

@PhilRunninger PhilRunninger merged commit d3becd1 into preservim:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge case in comparisons for directories with similar prefixes?
1 participant