-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vim 9.0 menu patch #1322
Vim 9.0 menu patch #1322
Conversation
Forcing resize after closing the menu to prevent issue #1321
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just went through this locally, and it seems to work for my Vim9 🎉
I have tested this locally, and it is working properly for me. # vim --version
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Aug 17 2022 21:21:22)
macOS version - arm64
Included patches: 1-217 # git head
commit fc85a6f07c2cd694be93496ffad75be126240068 (HEAD -> master, origin/master, origin/HEAD)
Author: Rod Elias <rodiney@gmail.com>
Date: Mon Jun 13 07:10:46 2022 -0300 |
Tested locally, works for me on Neovim 0.8.0. Please merge ASAP, because having screen real estate eaten by this bug is annoying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the actual blockers to getting this merged and released? |
I think someone just needs to click the merge button. From what I remember though, NERDTree has been looking to transition its maintainer for a while. I don't know how successful that process has been |
This issue was patched by Vim in newer versions, it just affected a few 9.0 releases, this pull request is still up so people can patch it locally if they decide to keep using older versions of Vim. |
EDIT:
This is only open for historical reasons and to make it easier to find.
This PR is a hotfix for the issue mentioned in #1321.
There is a problem in the early versions of Vim9 which prevents some parts of NERDTree from restoring their original size after a temporary window/pane resize. This patch forces a manual resize so deal with this issue.
I suggest you update your Vim if you are experiencing this problem instead of using this patch.
TL;DR Just update your Vim!
Description of Changes
Force resize after closing the menu to prevent issue #1321
New Version Info
Author's Instructions
MAJOR.MINOR.PATCH
version number. Increment the:MAJOR
version when you make incompatible API changesMINOR
version when you add functionality in a backwards-compatible mannerPATCH
version when you make backwards-compatible bug fixesCollaborator's Instructions