Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reveal functionality for Windows platform in fs_menu #1366

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

rzvxa
Copy link
Member

@rzvxa rzvxa commented Sep 3, 2023

Description of Changes

Adds similar functionality to Linux and Mac platforms for revealing the selected node in the file browser(in the case of Windows It's Windows Explorer)


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merging, tag the commit using these (Mac-compatible) bash commands:
    git checkout master
    git pull
    sed -n "$(grep -n -m2 '####' CHANGELOG.md | cut -f1 -d: | sed 'N;s/\n/,/')p" CHANGELOG.md | sed '$d'
    git tag -a $(read -p "Tag Name: " tag;echo $tag) -m"$(git show --quiet --pretty=%s)";git push origin --tags

@rzvxa
Copy link
Member Author

rzvxa commented Sep 3, 2023

@alerque This PR adds the missing Reveal in Explorer to the Windows platform.

alerque
alerque previously approved these changes Sep 4, 2023
Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'm also not on either macOS or Windows to test it. It would be nice if we could get at least one confirmation from another party that this is working for them.

@rzvxa
Copy link
Member Author

rzvxa commented Sep 4, 2023

This looks good to me, but I'm also not on either macOS or Windows to test it. It would be nice if we could get at least one confirmation from another party that this is working for them.

Mac functionality was already implemented before this PR, I just changed its text to match other shortcuts.

@alerque
Copy link
Member

alerque commented Sep 4, 2023

Great. Do we have 1 other Windows user that can give this a spin?

(If it goes too long with no review we'll probably just merge and let people complain if it broke, but I always try to get feedback/reviews for things I can't test even if they look sane.)

…eveal-windows-explorer

# Conflicts:
#	nerdtree_plugin/fs_menu.vim
@rzvxa
Copy link
Member Author

rzvxa commented Oct 22, 2023

@alerque Hi, Do you think it's fine to move forward with this PR? I personally would love to use it in my day-to-day life since I'm using this functionality on my Linux machine, after all, it adds a new functionality and won't break any existing one.

@rzvxa rzvxa merged commit 334542c into preservim:master Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants