Don't require user to type 'yes' to delete an empty directory #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeperri
force-pushed
the
delete-empty-directory
branch
from
8c90f57
to
d2509d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will use the normal "yN" delete prompt instead.
My reasoning is that if you expect that the directory is empty, and you see the "STOP!" prompt, you might get concerned that it's not actually empty and waste a couple of seconds going back and checking.
Potential concerns: if you were used to typing "yes", you might end up typing y, which would confirm deletion, then e, and then s, which would open the file that's now under your cursor in a new split. This could be mildly annoying if you were very accustomed to the way NERDTree works now.