Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed arrows for NERDTreeDirArrowExpandable and NERDTreeDirArrowCol… #546

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

gwilk
Copy link

@gwilk gwilk commented Feb 4, 2016

…lapsible
Arrows used so far ('▸' unicode 9656 and '▾' unicode 9662) can't be find in popular monotype fonts like Courier New, Liberation Mono or Lucida Console (while available in DejaVu Sans Mono or Consolas)
Characters '►' (unicode 9658) and '▼' (unicode 9660) are much more popular.

@PhilRunninger PhilRunninger merged commit f173f62 into preservim:master Sep 22, 2016
@arturoherrero
Copy link

@gwilk @PhilRunninger This change has made my arrows very big in the terminal (Vim) or in MacVim. I really like to have the previous size that looks much better.

Before:
before

After:
after

@arturoherrero
Copy link

Actually, I'm reading the README and it seems configurable, so probably I can configure in the .vimrc file. Anyway the default look and feel for a lot of users is going be as I've described.

@scrooloose
Copy link
Collaborator

Hmm, we have gone back and forward over the arrows before and settled on smaller arrows.

I'm of the opinion that we should revert to small arrows (purely for aesthetic reasons) and add an FAQ with instructions to change to large arrows for fonts that dont support small.

Thoughts?

@PhilRunninger
Copy link
Member

@scrooloose , I agree. The smaller ones look better. When I'd merged this in, I misread the if statement and thought these arrows were a Windows-only problem. The FAQ is already in the README. I'll go ahead and revert the merge if you give the thumbs up.

@PhilRunninger
Copy link
Member

@gwilk, I've reverted this pull request. To use the large arrows, you'll have to override them as shown in the FAQ section of the README.

@scrooloose
Copy link
Collaborator

@PhilRunninger all good mate, thanks for fixing.

Oh, I didn't spot that FAQ... I really need to learn to read 😄

@gwilk
Copy link
Author

gwilk commented Oct 14, 2016

OK. My point was, that the small arrows are missing in many popular fonts. Perhaps the fonts will be updated some day. For now, changing configuration is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants