Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #537: Fix dir arrows not functioning properly #548

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

adityanatraj
Copy link
Contributor

added characters that are special when within character
classes in a regular expression to the escape(...) call
when building s:dirArrows.

this does not fix when ' ' or '' are your dirArrows and you
can't open up subdirs. i think that's an issue with how nerdtree
distinguishes things to traverse in the filetree.

this fixes: #537

added characters that are special when within character
classes in a regular expression to the `escape(...)` call
when building `s:dirArrows`.

this does not fix when `' '` or `''` are your `dirArrows` and you
can't open up subdirs. i think that's an issue with how nerdtree
distinguishes things to traverse in the filetree.
@ghost
Copy link

ghost commented Feb 16, 2016

Please bring back the option

let g:NERDTreeDirArrows=0

This used to work fine, now it's gone, not sure why it was removed.

@adityanatraj
Copy link
Contributor Author

what did

let g:NERDTreeDirArrows=0

do ?

I'm sorry, I don't know what that did, I'm relatively new to NERDTree

@ghost
Copy link

ghost commented Mar 7, 2016

It disabled the ascii arrows in favor of + and - for directories.

On Sun, Mar 6, 2016 at 11:14 PM, Aditya Natraj notifications@github.com
wrote:

what did

let g:NERDTreeDirArrows=0

do ?

I'm sorry, I don't know what that did, I'm relatively new to NERDTree


Reply to this email directly or view it on GitHub
#548 (comment).

@adityanatraj
Copy link
Contributor Author

@mdu4rt3 I cannot add that option as feature changes/behaviors are outside the scope of this PR. This is simply to fix the current issue with the broken characters for dir arrows.

If you notice within the CHANGELOG here, the behavior you requested was purposefully removed.

@PhilRunninger
Copy link
Member

@adityanatraj , Thanks for providing this fix.

@PhilRunninger PhilRunninger merged commit 9ff2096 into preservim:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dir arrows not functioning properly
2 participants