Clean up the handler for the "x" mapping #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, pressing "x" on the tree root would result in unpredictable behavior. The user would either an receive an error message or the parent of the tree root (which is not visible) would be closed. This commit repairs this problem. In addition, some code duplication was removed.
alexanderscott
added a commit
to alexanderscott/nerdtree
that referenced
this pull request
Nov 21, 2017
* 'master' of https://github.com/scrooloose/nerdtree: (181 commits) Make the "o" mapping consistent with "x" Fix a problem with the "x" handler (preservim#768) Clean up the handler for the "x" mapping (preservim#767) Revert change to tab opening method (preservim#766) Add back support for "b:NERDTreeRoot" (preservim#765) Update the CHANGELOG Have new tabs open as the last tab (with '$') Add a note/warning to "TreeDirNode.activate()" Document "t" and "T" mappings in the quick help Silence messages when opening a file with "T" Fix handlers for "t" and "T" on bookmarks Explicitly call open() in "ui_glue.vim" callbacks Remove an unnecessary assignment Clean up the Creator.createTabTree() function Clean up the commentary in "creator.vim" Extract a common line to the top of a function Remove an unnecessary "else" clause Clean up the NERDTreeOpener constructor Merge pull request preservim#754 from branch comma-separated-file-size Merge pull request preservim#756 from mboughaba/master ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, pressing "x" on the tree root would result in
unpredictable behavior. The user would either an receive an error
message or the parent of the tree root (which is not visible) would
be closed. This commit repairs this problem.
In addition, some code duplication was removed.