BUGFIX: Allow ":NERDTreeFind" to discover hidden files #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PhilRunninger, I think this is the last NERDTree code I'll write before the new year... it's a pretty good one to end on! |
lifecrisis
changed the title
|
I'm going to go ahead and merge because I really want the functionality... this one has been bothering me for a while. I guess it's because I edit a lot of dot-files! I've reviewed it several times so it should be good. |
lifecrisis
added a commit
that referenced
this pull request
Jan 5, 2018
Here, a more accurate method of determining whether or not to show hidden files is used. A new method, "isHiddenUnder()" is defined for "Path" objects. This method is then used to set the flag for hidden files in the ":NERDTreeFind" command. Note that this function is likely to be useful elsewhere. Fixes #189.
|
D'oh! I forgot to review this one. I just ran a quick check of it, and it works properly on Mac. |
|
Thanks, @PhilRunninger!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #189 originally pointed out a bug in which
:NERDTreeFindcould not always properly reveal a hidden file. This PR adds a function that makes the behavior offindAndRevealPath()consistent in this respect.