Fixed error 'unknown function strcharpart' for older versions of Vim #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hav4ik
changed the title
|
@hav4ik Thanks for fixing that oversight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous commit (
d3a7cd2) resulted in a immediate crash when NERDTree is started, as shown in the screenshot below:This is due to the function
strcharpart(), which has been added to vim in commit vim/vim@58de0e2on April 14 2016 which is equivalent to the patch level 7.4.1730. One of the most popular operating systems, Ubuntu 16.04 LTS, is still using vim 7.4.1689, which doesn't have this function.So I added backward-compatibility, by checking
if exists("*strcharpart")