BUGFIX: Repair a problem with the 'u' mapping. #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the "nerdtree#ui_glue#UpDir()" function to fix a bug in the behavior of the 'u' mapping. To reproduce the bug: 1. Open a bookmarked directory with 'o' 2. Press 'u' twice, observing normal behavior 3. Open the same bookmark again with 'o' 4. Press 'u' again, observe the new root is closed The reason for this bug is that the parent node already existed and was closed by the second 'u' press in step two above. This commit fixes this bug by being careful to always open the new root and transplant the child node properly. Also, the internals of the function in question were refactored to make use of valuable NERDTree functions that ultimately help to reduce the amount of code needed for this operation.
PhilRunninger
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.