Bugfix - ensure keymaps dictionary exists before using it #852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized I might have introduced a bug in #851, I haven't been able to trigger it but I wanted to be safe rather then sorry.
The
KeyMap.Add
andKeyMaps.Remove
functions can't useKeyMap._all
to fetch the key map dictionary since they need to modify it, and it appears the dictionary returned by theKeyMap._all
function is a copy, and modifying the copy doesn't modify the underlyings:keyMaps
variable. However, using thes:keyMaps
variable directly is error prone since the variable will be undefined until the very first invocation ofKeyMap._all
.This PR invokes and discards the result of
KeyMap._all
prior to adding or removing any key maps froms:keyMaps
directly, just to ensures:keyMaps
is defined.