Unzoom NERDTree when opening a file #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2018 09:00
'go' does not trigger this new behavior, because focus remains in the NERDTree.
lifecrisis
approved these changes
Aug 25, 2018
There was a problem hiding this comment.
I think this is fine.
I'd suggest you consider what happens when opening a file leaves the current tab. Using t or using o when the file is already open in another tab will leave the current tab. It seems more natural to leave the NERDTree zoomed in the tab you left behind.
I don't use this feature, so I don't really care... I have my own plugin for adjusting the NERDTree's window size.
If the tab issue is not important to you, feel free to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #15.
IF
g:NERDTreeQuitOnOpen=0),o,i,s, ortTHEN unzoom NERDTree first.
We don't need to unzoom NERDTree if it's going to be closed when opening a file, and chances are the user wants it to remain zoomed the next time it's opened anyway.
go,gi,gs, andTdo not trigger this new behavior, because focus remains in theNERDTree.