Make sure the path to the bookmarks file exists before writing it. #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifecrisis
reviewed
Aug 25, 2018
There was a problem hiding this comment.
Hmmm...
I think we're being a little too helpful here. I would argue that making sure the path to the file exists and that the location is reachable (in terms of permissions) is the responsibility of the user. I would just let him know and close the issue.
Let me know what you think.
This change puts the burden on the user to make sure g:NERDTreeBookmarksFile is correctly set and the path it contains is present and has the proper permissions. If this is not the case, an error message is displayed. This is a better solution than to blindly create the path, when it may actually be impossible to do so.
|
@lifecrisis, I agree with your argument, but instead of letting the code crash the way it does now, I opted for a cleaner error message, as seen in my latest commit. |
lifecrisis
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435.