Fix opening sub-directories that have commas in their name. #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not escaped, commas will cause globpath() to search in multiple directories, none of which really exist.
PhilRunninger
added
PR Under Review
lifecrisis
approved these changes
Aug 25, 2018
There was a problem hiding this comment.
This definitely fixed the problem on Windows 10.
I was able to do the following:
- Create
dir,with,commas\using themamapping. - Create a
file.txtunder the new directory again with themamapping. - Use
oto open the directory and view the new child node.
Thus, I would say this issue is fixed. Again, superb catch!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #314
The key to fixing this was in the help file entry for the
globpath()function. If the path argument contains a comma, it will causeglobpath()to search in multiple non-existent directories.