Function "s:UI.getLineNum()" doesn't always work on cascades. #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
September 6, 2018 10:56
PhilRunninger
approved these changes
Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #529.
This was complicated as it involved refactoring a fairly complex function. This function has now been rewritten, and the style and logic are much cleaner, IMHO.
It's a very fundamental feature of the NERDTree that is used all over the place. So, we shouldn't treat this change without care. I suggest we use this for a while so that we can confirm that it works.
Let me know what you think. Each commit is very specific, so you can see what I did at each step.