Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the <C-J>/<C-K> motions, which currently fail with cascades #886

Merged
merged 8 commits into from
Sep 15, 2018
Merged

Fix the <C-J>/<C-K> motions, which currently fail with cascades #886

merged 8 commits into from
Sep 15, 2018

Conversation

lifecrisis
Copy link
Contributor

No description provided.

@lifecrisis
Copy link
Contributor Author

NOTE: The last two commits I added fix the J and K default mappings, which suffer from a similar issue. This is not to big of a problem, but it's quite annoying when you do run into it!

@lifecrisis
Copy link
Contributor Author

lifecrisis commented Sep 13, 2018 •
edited
Loading

My favorite type of PR is one in which I can fix a bug and remove more code than I add. I think this is a good one.

@lifecrisis lifecrisis changed the title Fix the <C-J>/<C-K> motions, which currently fail with cascades Fix the <C-J>/<C-K> motions, which currently fails with cascades Sep 13, 2018
@lifecrisis lifecrisis changed the title Fix the <C-J>/<C-K> motions, which currently fails with cascades Fix the <C-J>/<C-K> motions, which currently fail with cascades Sep 13, 2018
PhilRunninger
PhilRunninger approved these changes Sep 15, 2018
View reviewed changes
Copy link
Member

@PhilRunninger PhilRunninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'd never gotten in the habit of using those keystrokes, but now I just might start.

@lifecrisis lifecrisis merged commit fa6f215 into preservim:master Sep 15, 2018
lifecrisis added a commit that referenced this pull request Sep 15, 2018
@lifecrisis
Fix the <C-J>, <C-K>, J, and K default mappings (#886)
cd1f2c8 
These mappings currently fail on cascades.  This pull request fixes
this problem.
@lifecrisis lifecrisis deleted the jump-sib branch September 15, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilRunninger PhilRunninger PhilRunninger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lifecrisis @PhilRunninger