Catch all errors, not just NERDTree errors. #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When middle-clicking, the s:TreeFileNode.GetSelected() function is called along the way. If this is done outside of the NERDTree window, there is not "b:NERDTree" variable, and the "E121: Undefined variable" exception is thrown. This function was trying to catch only the NERDTree specific errors; thus, it let the Undefined variable exception slip by. This commit causes the function to catch all errors.
lifecrisis
reviewed
Oct 18, 2018
|
@PhilRunninger, I did some more digging, and I actually think this is okay. The problem is Vim. The So, I rescind my earlier comment. I approve of your change, here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893
When middle-clicking, the s:TreeFileNode.GetSelected() function is
called along the way. If this is done outside of the NERDTree window,
there is no "b:NERDTree" variable, and the "E121: Undefined variable"
exception is thrown. This function was trying to catch only the NERDTree
specific errors; thus, it let the Undefined variable exception slip by.
This commit forces the function to catch all errors.