Allow multi-character DirArrows #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 18, 2019 11:34
Actually, it's up to the user to make sure it's a single character after leading and trailing spaces are removed. Spaces need to be removed so that an accurate level of indentation can be calculated.
1. Replace the DirArrows with a single space. 2. Count the leading spaces. 3. Divide by 2. This allows users to specify multi-character arrows, where a spaces prevent characters printing on top of each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #931.
The problem with #931 was that the users specified DirArrows that were more than one character long to improve the spacing. This caused the indentation calculation to be incorrect.
The solution is to improve the algorithm that calculates indentation, treating multi-character DirArrows as one character for purposes of indentation calculation.