Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'g:tagbar_autoclose_netrw' was not actually really default to 0 #866

Conversation

Shane-XB-Qian
Copy link
Contributor

@Shane-XB-Qian Shane-XB-Qian commented Jan 13, 2024

#822
it seems did not actually really reset the default value to 0,
or just the init and doc, but the logic still was 1.
// and the logic seems was not correct, try to fix.

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
@raven42
Copy link
Collaborator

raven42 commented Jan 13, 2024

I did a quick test with this change, and it did not work as expected for me. I had the following windows open:

  • File Window
  • Tagbar Window
  • NerdTree Window

Then in my config file I have

let g:tagbar_autoclose_netrw = 1

With this my expected behavior is that when I type a :q on the file window, all three windows close. With the current code on perservim:master I see this behavior. When I checked out to your branch, I no longer see this behavior. When I type :q on your branch, I see the NerdTree window open still, but tagbar and the file window close.

Can you please describe the reasoning behind this change? What is the behavior you are expecting vs what is the behavior you are seeing?

@Shane-XB-Qian
Copy link
Contributor Author

Shane-XB-Qian commented Jan 13, 2024 via email

@raven42
Copy link
Collaborator

raven42 commented Jan 13, 2024

Ah ok, wonder if it is something with the vim version.

I'm currently using vim 8.2 still. I've played around a little bit with vim 9.0, but that isn't my main yet as I've seen some issues with plugins and such.

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Jan 11 2023 23:53:12)
Included patches: 1-3995, 4563, 4646, 4774, 4895, 4899, 4901, 4919

@Shane-XB-Qian
Copy link
Contributor Author

Shane-XB-Qian commented Jan 14, 2024 via email

@Shane-XB-Qian
Copy link
Contributor Author

upstream ticket in vim repo had been closed, and recently there are some vim window operation code/logic were patched, so supposed now it was ok? or whatever, please expressed your thinking there about if vim itself can make plugin's life easy.. 😄

@Shane-XB-Qian Shane-XB-Qian deleted the fix_tagbar_with_netrw_last_two branch February 27, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants