-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): add time_zone param #69
Conversation
420d496
to
4cf73f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 94.52% 94.66% +0.13%
==========================================
Files 15 15
Lines 932 956 +24
==========================================
+ Hits 881 905 +24
Misses 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you document this new parameter here: https://github.com/preset-io/elasticsearch-dbapi#connection-parameters
related Superset issue: apache/superset#16726
The documentation has been updated, please review |
The time_zone parameter is very important for users in non-UTC time zones. We need to add this parameter to adapt to different time zones.
This parameter affects the processing of the time function in the ES-SQL query.
https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-search-api.html
eg:
To demonstrate the role of time_zone, the
DATETIME_PARSE
function is used, butDATETIME_PARSE
can only be used after ES 7.8, so theES_SUPPORT_DATETIME_PARSE
parameter is added to the env