Skip to content

Commit

Permalink
fix: adjusted tab height (apache#13822)
Browse files Browse the repository at this point in the history
(cherry picked from commit 4187d9e)
  • Loading branch information
AAfghahi authored and henryyeh committed Apr 6, 2021
1 parent f81b746 commit 3396fe2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import {
LOCALSTORAGE_MAX_QUERY_AGE_MS,
} from '../../constants';

const TAB_HEIGHT = 64;
const TAB_HEIGHT = 90;

/*
editorQueries are queries executed by users passed from SqlEditor component
Expand Down Expand Up @@ -63,7 +63,6 @@ const StyledPane = styled.div`
flex-direction: column;
}
.tab-content {
overflow: hidden;
.alert {
margin-top: ${({ theme }) => theme.gridUnit * 2}px;
}
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/SqlLab/main.less
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ body {
position: relative;
background-color: @lightest;
overflow-x: auto;
overflow-y: hidden;
overflow-y: auto;

> .ant-tabs-tabpane {
position: absolute;
Expand Down
5 changes: 5 additions & 0 deletions superset-frontend/src/components/ProgressBar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,18 @@ const ProgressBar = styled(({ striped, ...props }: ProgressBarProps) => (
<AntdProgress {...props} />
))`
line-height: 0;
position: static;
.ant-progress-inner {
position: static;
}
.ant-progress-outer {
${({ percent }) => !percent && `display: none;`}
}
.ant-progress-text {
font-size: ${({ theme }) => theme.typography.sizes.s}px;
}
.ant-progress-bg {
position: static;
${({ striped }) =>
striped &&
`
Expand Down

0 comments on commit 3396fe2

Please sign in to comment.