Skip to content

Commit

Permalink
Revert "fix(Charts): Set max row limit + removed the option to use an…
Browse files Browse the repository at this point in the history
… empty row limit value (apache#25579)"

This reverts commit f556ef5.
  • Loading branch information
sadpandajoe committed Oct 24, 2023
1 parent e4173d9 commit 5941506
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 55 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ import {
isDefined,
hasGenericChartAxes,
NO_TIME_RANGE,
validateNonEmpty,
validateMaxValue,
} from '@superset-ui/core';

import {
Expand Down Expand Up @@ -245,12 +243,7 @@ const row_limit: SharedControlConfig<'SelectControl'> = {
type: 'SelectControl',
freeForm: true,
label: t('Row limit'),
clearable: false,
validators: [
validateNonEmpty,
legacyValidateInteger,
v => validateMaxValue(v, 100000),
],
validators: [legacyValidateInteger],
default: 10000,
choices: formatSelectOptions(ROW_LIMIT_OPTIONS),
description: t(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,3 @@ export { default as legacyValidateNumber } from './legacyValidateNumber';
export { default as validateInteger } from './validateInteger';
export { default as validateNumber } from './validateNumber';
export { default as validateNonEmpty } from './validateNonEmpty';
export { default as validateMaxValue } from './validateMaxValue';

This file was deleted.

This file was deleted.

0 comments on commit 5941506

Please sign in to comment.