fix(chart-list): Hide 'Dashboards added to' column. (apache#22475)

(cherry picked from commit 7a94f3a)
preset-io · Dec 20, 2022 · f226804 · f226804
1 parent 6b350a1
commit f226804
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts b/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts
@@ -58,7 +58,7 @@ describe('Charts list', () => {
     cy.preserveLogin();
   });
 
-  describe('Cross-referenced dashboards', () => {
+  describe.skip('Cross-referenced dashboards', () => {
     beforeEach(() => {
       cy.createSampleDashboards([0, 1, 2, 3]);
       cy.createSampleCharts([0]);
@@ -105,6 +105,8 @@ describe('Charts list', () => {
 
   describe('list mode', () => {
     before(() => {
+      cy.createSampleDashboards([0, 1, 2, 3]);
+      cy.createSampleCharts([0]);
       visitChartList();
       setGridMode('list');
     });
@@ -114,11 +116,11 @@ describe('Charts list', () => {
       cy.getBySel('sort-header').eq(1).contains('Chart');
       cy.getBySel('sort-header').eq(2).contains('Visualization type');
       cy.getBySel('sort-header').eq(3).contains('Dataset');
-      cy.getBySel('sort-header').eq(4).contains('Dashboards added to');
-      cy.getBySel('sort-header').eq(5).contains('Modified by');
-      cy.getBySel('sort-header').eq(6).contains('Last modified');
-      cy.getBySel('sort-header').eq(7).contains('Created by');
-      cy.getBySel('sort-header').eq(8).contains('Actions');
+      // cy.getBySel('sort-header').eq(4).contains('Dashboards added to');
+      cy.getBySel('sort-header').eq(4).contains('Modified by');
+      cy.getBySel('sort-header').eq(5).contains('Last modified');
+      cy.getBySel('sort-header').eq(6).contains('Created by');
+      cy.getBySel('sort-header').eq(7).contains('Actions');
     });
 
     it('should sort correctly in list mode', () => {

diff --git a/superset-frontend/src/views/CRUD/chart/ChartList.tsx b/superset-frontend/src/views/CRUD/chart/ChartList.tsx
@@ -401,6 +401,7 @@ function ChartList(props: ChartListProps) {
         accessor: 'dashboards',
         disableSortBy: true,
         size: 'xxl',
+        hidden: true,
       },
       {
         Cell: ({