fix: Explore popovers issues (#11428) #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix spaces and comas not working in filter popover * Fix popup not opening automatically * Add e2e test * Remove only from test * Remove redundant test, add checking label content * Add comments to e2e test * Fix unit test * Use destructuring * Always open popup for functions and saved metrics, too * Fix popover for adhoc metrics too * Small refactor to consistency * Refactor for consistency * Remove redundant functions * Test fix Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> (cherry picked from commit b2636f0)
Codecov Report
@@ Coverage Diff @@
## preset/release-43-branch #35 +/- ##
============================================================
- Coverage 65.79% 61.60% -4.20%
============================================================
Files 838 838
Lines 39874 39867 -7
Branches 3655 3654 -1
============================================================
- Hits 26237 24559 -1678
- Misses 13536 15127 +1591
- Partials 101 181 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
approved these changes
Oct 31, 2020
mistercrunch
changed the base branch from
preset/release-43-branch
to
release-43
preset-machine
pushed a commit
that referenced
this pull request
Nov 30, 2021
* Fix issue with large timestamp arrays Math.max and Math.min produce "Maximum call stack size exceeded" errors when used with large arrays (see: https://stackoverflow.com/questions/18308700/chrome-how-to-solve-maximum-call-stack-size-exceeded-errors-on-math-max-apply) * fix issue when viewport.zoom < 0 * Update packages/superset-ui-legacy-preset-chart-deckgl/src/utils/time.js Sure. Style changed Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry is essentially/simpy apache#11428 with a single/simple merge conflict fixed in Cypress tests, it's on top 5579772
Simply
git cherry-pick -x 45e767a7dfbc2b1d3c5078324f0ffc97dc571560to pick on top of the current release