Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbt cloud): modal header overlap in db connection #514

Merged
merged 1 commit into from
May 18, 2023

Conversation

lilykuang
Copy link

SUMMARY

  • fixing modal header overlap in db connection

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -2.65 ⚠️

Comparison is base (843fe63) 59.63% compared to head (c89b3cb) 56.98%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           database-registry     #514      +/-   ##
=====================================================
- Coverage              59.63%   56.98%   -2.65%     
=====================================================
  Files                    518     1951    +1433     
  Lines                  36490    75410   +38920     
  Branches                   0     8183    +8183     
=====================================================
+ Hits                   21760    42975   +21215     
- Misses                 14730    30333   +15603     
- Partials                   0     2102    +2102     
Flag Coverage Δ
hive 53.17% <ø> (ø)
presto ?
python 59.42% <ø> (-0.21%) ⬇️
unit 53.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/features/databases/DatabaseModal/styles.ts 77.66% <ø> (ø)

... and 1436 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lilykuang lilykuang merged commit 710185c into database-registry May 18, 2023
@lilykuang lilykuang deleted the modal-header-fix branch May 18, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants