Additional CSRF deactivation checks #1720
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamgregory
force-pushed
the
additional-crsf-checks
branch
from
3b764cb to
8d3211f
Compare
…sion_gte?` and `version_lte?` helpers
jamgregory
force-pushed
the
additional-crsf-checks
branch
from
8d3211f to
b9426a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds additional CSRF deactivation checks as detailed in #1545:
config.action_controller.allow_forgery_protection = falseskip_before_action :verify_authenticity_tokenprotect_from_forgery except: :indexprotect_from_forgery only: :showprotect_from_forgery if: -> { ... }protect_from_forgery unless: -> { ... }(this also includes the work in #1719 as that's required for the new checks to function correctly)