Add ruby 3.2 to CI #1759
Merged
Add ruby 3.2 to CI #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoivo
force-pushed
the
main
branch
3 times, most recently
from
183ac08 to
55f15ee
Compare
|
Sorry if you think I changed to many things in one MR. It is less work on one MR when it soo related. |
| } | ||
| end | ||
|
|
||
| def test_ruby_2_7_eol | ||
| assert_warning check_name: "EOLRuby", |
There was a problem hiding this comment.
This will break again on 2023-03-31 (or maybe sooner).
Can you wrap it in code like this? (This is what's done here)
Date.stub :today, Date.parse('2023-02-10') do
assert_warning ...
endThere was a problem hiding this comment.
It is updated. I wraped the scann method
It is useful to see which exact version it is running since when we specify cimg/ruby:3.2 we don't know if we will get 3.2.0 or 3.2.1. We will always get the most recent but now it is printed.
ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) https://app.circleci.com/pipelines/github/presidentbeef/brakeman/953/workflows/5e965ee8-4b14-4e72-a0b6-c3793242093f/jobs/6340
Based on that the newer ruby image for circleci/ruby is 3.0.3 and cimg/ruby has 3.2.1. I thinkg cimg/ruby is better overall. It is also procuced bu CircleCI. CircleCI has a repo https://github.com/CircleCI-Public/cimg-overview where they document so of the build status and here it states that `cimg/ruby` replaces `circleci/ruby`. Also https://github.com/CircleCI-Public/cimg-ruby states "This image is designed to supercede the legacy CircleCI Ruby image, circleci/ruby."
|
Thanks! |
Repository owner
locked and limited conversation to collaborators
May 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something fails on when I use ruby 3.2 in production. I think this should work but it is allways good to test have it in ci too.