Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement apitoken authentication method for JIRA issue tracker #174

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

preslavmihaylov
Copy link
Owner

@preslavmihaylov preslavmihaylov commented Feb 9, 2022

related to #60

Implemented support for authenticating with Atlassian-hosted JIRA servers using API Token authentication type.

other changes

  • I changed the JIRA task status derivation to be based on the status category versus the status name, because the status name is user-defined, but the status category is not.
  • I updated the youtrack server used in integration tests because the previous one was not maintained by the contributor who submitted it, hence, youtrack automatically deleted it.
  • Added a space after reading the token from cmdline to make the output prettier
  • integration tests for jira incloud hosting. Note that the new integration test is currently failing because the env secret in use will get applied after merging the PR to master

@preslavmihaylov preslavmihaylov requested a review from mehdy February 9, 2022 11:00
@preslavmihaylov
Copy link
Owner Author

Hi @mehdy mind a quick review on this one?

@mehdy
Copy link
Collaborator

mehdy commented Feb 9, 2022

Not at all! Of course :)

Copy link
Collaborator

@mehdy mehdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine. Just to be sure the test fails because it has to be merged to master to see the env, right?

authmanager/authmanager.go Show resolved Hide resolved
@preslavmihaylov
Copy link
Owner Author

yeah, the failing test is because the secret for the jria integration is not visible until this has landed in master.

Copy link
Collaborator

@mehdy mehdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks good to me!

@preslavmihaylov preslavmihaylov merged commit b2701e2 into master Feb 11, 2022
@preslavmihaylov preslavmihaylov deleted the jira-apitoken-auth branch August 21, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants