Validate origin format based on issue tracker #47
Conversation
|
I'm not sure how to validate the origin for Jira or Redmine, but this should validate the others properly |
|
Thanks for the comments. I fixed everything you mentioned, but I have a couple of questions. Why does |
| @@ -0,0 +1,2 @@ | |||
| origin: https://github.com/user/project | |||
There was a problem hiding this comment.
Could you also add valid configs for all supported issue trackers:
- Without a scheme provided - e.g.
github.com/user/project - With
wwwprovided - e.g.www.github.com/user/projectandhttps://www.github.com/user/project
The tests all pass when I run them from latest master: Could you try running the test suite from latest master & see if they pass? As for the Currently, your validation is incompatible with the rest but as more validations are added, there will be independent issues \w configurations which can be reported to the user. |
config/config.go
Outdated
| @@ -82,6 +90,14 @@ func (l *Local) Validate() []error { | |||
| errors = append(errors, err) | |||
| } | |||
|
|
|||
| if 0 == len(errors) { | |||
There was a problem hiding this comment.
This check is dependent on the order of validations. This shouldn't happen as this piece of validation might as well become first in line in the future.
Instead, change your condition to be independent from the errors array by validating that the issue tracker is not empty:
if l.IssueTracker != "" {
...
}
|
Blocked by #54 |
|
Hey, the PR blocking this one is now merged. Please pull latest master & continue from there (to enable the CI checks). |
|
I figured out the testing issue on my end, added a bunch of tests for the regex, and fixed the regex according to your comments. LMK if there's anything else to add. |
Solves #25