Add go.mod #103
Add go.mod #103
Conversation
|
@VojtechVitek in order to make sure this change is working I've renamed the project in my fork, tagged a relase with Just opened golang/go#25494 will follow it and apply fixes in this branch (if necessary) before declaring this ready to be merged :) |
As vgo proposes from version v2.0.0 there's supposed to be a /v2 in the module name. For users this means that they have to import goose as `github.com/pressly/goose/v2`. For just using the goose binary, nothing changes. See: https://blog.golang.org/versioning-proposal At some point (CL: 105215) vgo started supporting and preferring unquoted strings in mod files. This change unquotes everything.
|
This took less than expected. There are two proposed CLs that fix the reported issue. You could see how to test (and use my fork for the purpose) in the issue's description. The PR is now tested and now ready to be merged :) |
| @@ -0,0 +1,8 @@ | |||
| module github.com/pressly/goose/v2 | |||
There was a problem hiding this comment.
Why do we need /v2 ?
Does the consumer of this package need to reference "v2" in all import statements too?
There was a problem hiding this comment.
If there's no /v2 in the module name, vgo can use either tip of master or latest v1.. release. Yes, all the import statements will need this /v2, too.
When developers reach v2, semantic import versioning means that a /v2/ is added to the import path at the end of the module root prefix: my/thing/v2/sub/pkg. There are good reasons for this convention, as described in the earlier post, but it is still a departure from existing tools. Realizing this, vgo will not use any v2 or later tag in a source code repository without first checking that it has a go.mod with a module path declaration ending in that major version (for example, module "my/thing/v2"). Vgo uses that declaration as evidence that the author is using semantic import versioning to name packages within that module. This is especially important for multi-package modules, since the import paths within the module must contain the /v2/ element to avoid referring back to the v1 module.
There was a problem hiding this comment.
Goose don't have version tag eat. Please add tag v0.1.0 or v1.0.0 and use module module github.com/pressly/goose
There was a problem hiding this comment.
This repo has git tags. Latest is v2.3.0.
There was a problem hiding this comment.
Oh. Sorry. Yes, vgo want major version in module.
|
Ok. Maybe in v3 will realise #63 ) |
|
@eaglemoor very much possible. We actually came up with an interesting approach internally. Use timestamps in development branch, and make it a serial numbers on git merge (via simple merge bot). |
As stated in golang/go#24384:
Thus it's impossible to add anything other than version 1.0 of this package as dependency in project built with vgo.