Fix creating non-bucketed empty partition #12119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where creating empty parition using CALL statement throws exceptions when using file based metastore implementation.
electrum
suggested changes
Dec 21, 2018
| @@ -1220,6 +1220,13 @@ public HiveInsertTableHandle beginInsert(ConnectorSession session, ConnectorTabl | |||
| Map<List<String>, ComputedStatistics> partitionComputedStatistics = createComputedStatisticsToPartitionMap(computedStatistics, partitionedBy, columnTypes); | |||
|
|
|||
| for (PartitionUpdate partitionUpdate : partitionUpdates) { | |||
| if (partitionUpdate.getFileNames().size() == 0) { | |||
| @@ -1220,6 +1220,13 @@ public HiveInsertTableHandle beginInsert(ConnectorSession session, ConnectorTabl | |||
| Map<List<String>, ComputedStatistics> partitionComputedStatistics = createComputedStatisticsToPartitionMap(computedStatistics, partitionedBy, columnTypes); | |||
|
|
|||
| for (PartitionUpdate partitionUpdate : partitionUpdates) { | |||
| if (partitionUpdate.getFileNames().size() == 0) { | |||
| HiveWriteUtils.createDirectory( | |||
There was a problem hiding this comment.
I don't think creating the directory here is there correct place. We should be doing it in SemiTransactionalHiveMetastore as part of the commit. We probably also need to handle it in the rollback cleaup. @haozhun should take a look
| " FORMAT = 'ORC', " + | ||
| " partitioned_by = ARRAY['p_varchar'] " + | ||
| ") " + | ||
| "AS " + |
There was a problem hiding this comment.
Creating an empty table should be sufficient. We should be able to create a new table and then add an empty partition. Is there a reason why another partition was needed, or something you wanted test?
| assertUpdate(format("" + | ||
| "CREATE TABLE %s " + | ||
| "WITH ( " + | ||
| " FORMAT = 'ORC', " + |
There was a problem hiding this comment.
Nit: lowercase the name format and use consistent indentation with the other property (two spaces)
|
Superseded by #12204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where creating empty parition using CALL statement
throws exceptions when using file based metastore implementation.
#12002