-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of non-deterministic filters in SelectiveStreamReaders #13278
Conversation
Would you add a test that fails without this change? You can make an array of timestamps from shipdate, commitdate and receiptdate: |
47df2de
to
6accbb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
6accbb7
to
5c1187b
Compare
presto-tests/src/main/java/com/facebook/presto/tests/H2QueryRunner.java
Outdated
Show resolved
Hide resolved
5c1187b
to
ad15392
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhhari Looks good % one question below
presto-tests/src/main/java/com/facebook/presto/tests/H2QueryRunner.java
Outdated
Show resolved
Hide resolved
fc9292a
to
7eaf05a
Compare
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
7eaf05a
to
0f23f31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhhari Looks good to me. Thanks for all these fixes.
I'd update commit message to Fix handling of non-deterministic filters in SelectiveStreamReaders
for clarity.
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Show resolved
Hide resolved
0f23f31
to
99b722a
Compare
No description provided.