Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce typeMetadata to hive-metastore's Column #17055

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Introduce typeMetadata to hive-metastore's Column #17055

merged 1 commit into from
Dec 13, 2021

Conversation

mengdilin
Copy link
Contributor

@mengdilin mengdilin commented Dec 1, 2021 •
edited
Loading

Test plan:

  • existing unit tests passed
  • new unit test passed

Hive Changes

  • Column has an additional typeMetadata field that can be used by ColumnConverter to transform a hive type to presto type
  • ColumnConverter interface transforms Column type to and from apache FieldSchema
  • HiveColumnConverter preserves existing column <-> fieldschema transformation behavior
== NO RELEASE NOTES ==

@linux-foundation-easycla
Copy link

CLA Not Signed

  • ❌ The commit (c7a6d8e008bf84c1337184f73843ad862f624abf ,a41f49df175dc05d475b4ec8b74838d70d56aa6c ,9ee2a57e5140fe3e81d31de4ec175cca4c231efd ,dd6cc6c57db9f91258af03ce805b7fe64bf12f11 ,aea8611462660d23ffd4c0519b8da0a6019e6453 ,04aa45e04619e326e218077884cd4bc661277b32 ,0d1b8758522f18aa2be43499dbb8f4fec13f15fb ,04ec73aa593cbc513c0e8cb4fa7a70a66856a222 ,353f66365f2b6fc76343142eb78fd529f501dc04) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

@mengdilin mengdilin marked this pull request as ready for review December 1, 2021 21:44
@linux-foundation-easycla
Copy link

CLA Not Signed

  • ❌ The commit (c7a6d8e008bf84c1337184f73843ad862f624abf ,a41f49df175dc05d475b4ec8b74838d70d56aa6c ,9ee2a57e5140fe3e81d31de4ec175cca4c231efd ,dd6cc6c57db9f91258af03ce805b7fe64bf12f11 ,aea8611462660d23ffd4c0519b8da0a6019e6453 ,04aa45e04619e326e218077884cd4bc661277b32 ,0d1b8758522f18aa2be43499dbb8f4fec13f15fb ,04ec73aa593cbc513c0e8cb4fa7a70a66856a222 ,353f66365f2b6fc76343142eb78fd529f501dc04 ,00680069b9ee0e6ee6c766f057dfc7824020e5f9) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

@highker highker self-requested a review December 2, 2021 05:06
@linux-foundation-easycla
Copy link

CLA Not Signed

  • ❌ The commit (c7a6d8e008bf84c1337184f73843ad862f624abf ,a41f49df175dc05d475b4ec8b74838d70d56aa6c ,9ee2a57e5140fe3e81d31de4ec175cca4c231efd ,dd6cc6c57db9f91258af03ce805b7fe64bf12f11 ,aea8611462660d23ffd4c0519b8da0a6019e6453 ,04aa45e04619e326e218077884cd4bc661277b32 ,0d1b8758522f18aa2be43499dbb8f4fec13f15fb ,04ec73aa593cbc513c0e8cb4fa7a70a66856a222 ,353f66365f2b6fc76343142eb78fd529f501dc04 ,00680069b9ee0e6ee6c766f057dfc7824020e5f9 ,b5a23ce2e12ba76ba4f21dbff8f4b5eafa9906a2) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

highker
highker reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@highker highker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks legit. Let's discuss in person on:

  • test dependencies on presto-facebook
  • coding style and a lot of code movement
  • release note
  • separate vs stash commits
  • easy CLA
  • re-request reviews

...e-metastore/src/main/java/com/facebook/presto/hive/metastore/thrift/ThriftHiveMetastore.java Outdated Show resolved Hide resolved
...metastore/src/main/java/com/facebook/presto/hive/metastore/thrift/ThriftMetastoreModule.java Show resolved Hide resolved
...ive-metastore/src/test/java/com/facebook/presto/hive/metastore/TestCachingHiveMetastore.java Outdated Show resolved Hide resolved
...o-hive-metastore/src/test/java/com/facebook/presto/hive/metastore/TestHiveMetastoreUtil.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java Outdated Show resolved Hide resolved
@linux-foundation-easycla
Copy link

CLA Not Signed

@mengdilin mengdilin force-pushed the typeURI branch 2 times, most recently from 6edd0b9 to 5ac9e7b Compare December 7, 2021 17:46
@linux-foundation-easycla
Copy link

CLA Not Signed

@mengdilin mengdilin force-pushed the typeURI branch 5 times, most recently from 6fdabdb to 2132e5f Compare December 7, 2021 22:43
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 7, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ mengdilin (0222ede7bdea58a70a8ff0b118b0b3d1cce130cb)

highker
highker reviewed Dec 8, 2021
View reviewed changes
Copy link
Contributor

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nits only

...metastore/src/main/java/com/facebook/presto/hive/metastore/thrift/ThriftMetastoreModule.java Show resolved Hide resolved
...metastore/src/test/java/com/facebook/presto/hive/metastore/thrift/InMemoryHiveMetastore.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HivePageSourceProvider.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HivePartitionManager.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java Outdated Show resolved Hide resolved
@WillsonHG WillsonHG mentioned this pull request Dec 8, 2021
Closed
@mengdilin mengdilin mentioned this pull request Dec 8, 2021
Open
@mengdilin mengdilin force-pushed the typeURI branch 4 times, most recently from 7110cc6 to aec3e84 Compare December 9, 2021 04:01
@highker highker self-assigned this Dec 9, 2021
@highker
Copy link
Contributor

highker commented Dec 9, 2021

The test failure is related

@highker highker merged commit 3d2d556 into prestodb:master Dec 13, 2021
@mengdilin mengdilin deleted the typeURI branch February 14, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@highker highker highker approved these changes

Assignees

@highker highker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mengdilin @highker