Ensure Parameters are in proper order for queries having WITH clause #17083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any chance of being merged in the next version? Very important fix for us. Thank you! |
|
hi @v-jizhang could you please rebase this PR? I will take a look |
v-jizhang
force-pushed
the
parameters-proper-order
branch
from
9c366a8 to
a45b56b
Compare
Cherry-pick of trinodb/trino#1529 Fixes prestodb#17012 Co-authored-by: praveenkrishna <praveenkrishna@tutanota.com>
v-jizhang
force-pushed
the
parameters-proper-order
branch
from
a45b56b to
e7974ed
Compare
|
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of trinodb/trino#1529
Fixes #17012
Co-authored-by: praveenkrishna praveenkrishna@tutanota.com
Test plan - Added a test.