Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cast(ObjectId() as string) in mongodb connector #17225

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Add cast(ObjectId() as string) in mongodb connector #17225

merged 1 commit into from
Mar 29, 2022

Conversation

Eywek
Copy link
Contributor

@Eywek Eywek commented Jan 25, 2022

fixes #14338

== RELEASE NOTES ==

MongoDB Changes
* add CAST(ObjectId() as STRING)

@rschlussel
Copy link
Contributor

This is still a draft. Are you planning to add more to it?

@rschlussel
Copy link
Contributor

@Eywek If you are done, can you make this no longer a draft so I can merge it?

@Eywek
Copy link
Contributor Author

Eywek commented Mar 24, 2022

Sorry, I haven't seen previous comments, it's ready to merge!

@Eywek Eywek marked this pull request as ready for review March 24, 2022 15:11
@rschlussel
Copy link
Contributor

Thank you! can you rebase and push your branch again to restart the tests?

@Eywek
Copy link
Contributor Author

Eywek commented Mar 24, 2022

Done!

@rschlussel
Copy link
Contributor

sorry can you rebase one more time. a fix for presto-docs is landed now.

@Eywek
Copy link
Contributor Author

Eywek commented Mar 28, 2022

yep, it's done

@rschlussel rschlussel merged commit f903bcb into prestodb:master Mar 29, 2022
@mshang816 mshang816 mentioned this pull request May 17, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschlussel rschlussel rschlussel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cast MongoDB ObjectID as VARCHAR
2 participants
@Eywek @rschlussel