Fix infinite loop during planning caused by PickTableLayout #17720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@highker you did approve this PR at #16627 but it was missing few tests. |
NikhilCollooru
requested changes
May 9, 2022
| } | ||
| HashTables other = (HashTables) obj; | ||
| return Arrays.equals(this.hashTables, other.hashTables) && | ||
| Objects.equals(this.expectedHashTableCount, other.expectedHashTableCount); |
There was a problem hiding this comment.
expectedHashTableCount is of primitive type int. We can directly compare the values as it is much more efficient than using Object.equals
this.expectedHashTableCount == other.expectedHashTableCount
| return false; | ||
| } | ||
| ArrayBlock other = (ArrayBlock) obj; | ||
| return Objects.equals(this.arrayOffset, other.arrayOffset) && |
There was a problem hiding this comment.
For primitive types like int, please directly compare their values instead of using Object.equals , here and in other files.
|
@v-jizhang Please squash the commits into one commit. The code changes look good. |
Replaces prestodb#16627 Co-authored-by: Brian Li <librian415@gmail.com>
Squashed. Thank you! |
NikhilCollooru
approved these changes
May 10, 2022
rschlussel
approved these changes
May 10, 2022
feilong-liu
added a commit
to feilong-liu/presto
that referenced
this pull request
Sep 1, 2022
Custom hashcode and equal functions are introduced for xxxBlock in PR prestodb#17720, where content in the corresponding block rather than the object itself are used in hashcode and equal function computation. However, xxxBlockBuilder which also extends from Block interface is left behind. In this commit, we override such functions for block builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #16627
Co-authored-by: Brian Li librian415@gmail.com
Test plan - Added a test.