Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SHOW SESSION LIKE #17752

Merged
merged 1 commit into from
May 14, 2022

Conversation

amitkdutta
Copy link
Contributor

@amitkdutta amitkdutta commented May 12, 2022

Porting from trinodb/trino#1688

== RELEASE NOTES ==

General Changes
* Add support for ``LIKE`` predicate to ``SHOW SESSION``

@amitkdutta amitkdutta requested a review from a team as a code owner May 12, 2022 07:27
@amitkdutta amitkdutta requested a review from presto-oss May 12, 2022 07:27
@NikhilCollooru NikhilCollooru self-requested a review May 12, 2022 07:44
@NikhilCollooru
Copy link
Contributor

Please follow the commit guidelines when cherry-picking from other projects
https://github.com/prestodb/presto/wiki/Review-and-Commit-guidelines#attribution

Copy link
Contributor

@NikhilCollooru NikhilCollooru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we also port the test changes from TestSqlParserErrorHandling
  • Can we also add the new file TestShowQueries and port the corresponding test changes.

@mbasmanova mbasmanova requested a review from aweisberg May 12, 2022 11:49
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition.

@@ -7,12 +7,13 @@ Synopsis

.. code-block:: none

SHOW SESSION
SHOW SESSION [ LIKE pattern ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also document the ESCAPE clause?

@mbasmanova
Copy link
Contributor

  • Can we also port the test changes from TestSqlParserErrorHandling
  • Can we also add the new file TestShowQueries and port the corresponding test changes.

+1

@amitkdutta amitkdutta force-pushed the show_session_like branch from 3b0ecd6 to c315bf0 Compare May 13, 2022 00:55
@amitkdutta
Copy link
Contributor Author

amitkdutta commented May 13, 2022

  • TestSqlParserErrorHandling
  • Can we also port the test changes from TestSqlParserErrorHandling

    • Can we also add the new file TestShowQueries and port the corresponding test changes.

Included tests from TestSqlParserErrorHandling and TestShowQueries. Instead of adding a separate file for TestShowQueries, added tests in AbstractTestQueries.java that already included SHOW SESSION tests. This way pulling changes into LocalQueryRunner was not required and it was diverged a lot to merge here.

@amitkdutta amitkdutta force-pushed the show_session_like branch 3 times, most recently from 34a1556 to 4c5e944 Compare May 13, 2022 06:02
@mbasmanova mbasmanova changed the title Add show session like synax support. Add support for SHOW SESSION LIKE May 13, 2022
@amitkdutta amitkdutta force-pushed the show_session_like branch from 4c5e944 to a58c39e Compare May 14, 2022 00:12
Copy link
Contributor

@NikhilCollooru NikhilCollooru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change the commit title to "Add support for SHOW SESSION LIKE"

@amitkdutta amitkdutta force-pushed the show_session_like branch 2 times, most recently from 0b3e08f to a7081e4 Compare May 14, 2022 04:17
Cherry-pick of trinodb/trino#1688

Co-authored-by: Praveen Krishna <praveenkrishna@tutanota.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants