-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SHOW SESSION LIKE #17752
Conversation
Please follow the commit guidelines when cherry-picking from other projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can we also port the test changes from
TestSqlParserErrorHandling
- Can we also add the new file
TestShowQueries
and port the corresponding test changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice addition.
@@ -7,12 +7,13 @@ Synopsis | |||
|
|||
.. code-block:: none | |||
|
|||
SHOW SESSION | |||
SHOW SESSION [ LIKE pattern ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you also document the ESCAPE clause?
+1 |
3b0ecd6
to
c315bf0
Compare
Included tests from |
34a1556
to
4c5e944
Compare
4c5e944
to
a58c39e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change the commit title to "Add support for SHOW SESSION LIKE"
presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java
Show resolved
Hide resolved
0b3e08f
to
a7081e4
Compare
presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java
Outdated
Show resolved
Hide resolved
presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java
Outdated
Show resolved
Hide resolved
Cherry-pick of trinodb/trino#1688 Co-authored-by: Praveen Krishna <praveenkrishna@tutanota.com>
a7081e4
to
7116710
Compare
Porting from trinodb/trino#1688