Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing LocalMode to DistributedClusterStats #17817

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Introducing LocalMode to DistributedClusterStats #17817

merged 1 commit into from
Jun 23, 2022

Conversation

kaur-h
Copy link
Contributor

@kaur-h kaur-h commented Jun 1, 2022 •
edited
Loading

Description - Adding local mode to the existing cluster endpoint so that it can be easier to find out which queries are running on the local coordinator instead of the whole cluster when running disaggregated coordinator mode. Figuring out local information can help with debugging purposes.

Test plan - Created a unit test that runs and queues multiple queries on different coordinators. The test checks that if local mode is enabled when requesting statistics from a cluster, the amount of queries that are running locally on that specific coordinator are returned instead of the amount of queries running on the whole cluster.

== RELEASE NOTES ==

General Changes
* Add support for local mode on ``/v1/cluster/`` to get information on locally running/queued queries. Can be enabled with the ``includeLocalInfoOnly`` property.

@kaur-h kaur-h requested a review from a team as a code owner June 1, 2022 01:00
@kaur-h kaur-h requested a review from presto-oss June 1, 2022 01:00
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 1, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kaur-h (63e186c69e0bd011b34da762eb315954cbe2a611, 042b248f32c1bb4ca83cbb2c0d21dd7f039dfee5)

@swapsmagic
Copy link
Contributor

  • Maven checks and some tests are failing, can you make sure they pass.
  • Also fix this Missing CLA Authorization test by following the onboarding guide.
  • Release Notes: replace ClusterStatsResource with /v1/cluster/

@swapsmagic
Copy link
Contributor

  • Merge both commits into single one.

@kaur-h kaur-h force-pushed the ClusterStatsLocalInfo branch from cd9ad16 to c895933 Compare June 1, 2022 20:37
@kaur-h kaur-h force-pushed the ClusterStatsLocalInfo branch from c895933 to ccecd77 Compare June 2, 2022 03:20
swapsmagic
swapsmagic approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@swapsmagic swapsmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update release note /v1/cluster with backquote.

tdcmeehan
tdcmeehan approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdcmeehan tdcmeehan merged commit 439f31f into prestodb:master Jun 23, 2022
@highker highker mentioned this pull request Jul 6, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdcmeehan tdcmeehan tdcmeehan approved these changes

@swapsmagic swapsmagic swapsmagic approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaur-h @swapsmagic @tdcmeehan