Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pinot Connector] Enable pinot grpc by default #17819

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Jun 1, 2022

Pinot side has by default turn on grpc query endpoint, so it makes sense to turn on grpc endpoint by default as well.

Note that this won't impact existing users who don't turn on grpc, the fallback behavior to netty query endpoint happens automatically.

== RELEASE NOTES ==

Pinot Changes
* Prefer querying Pinot server grpc endpoint by default (through config `pinot.use-streaming-for-segment-queries`).

@xiangfu0 xiangfu0 requested a review from a team as a code owner June 1, 2022 05:58
@xiangfu0 xiangfu0 requested a review from presto-oss June 1, 2022 05:58
@xiangfu0
Copy link
Contributor Author

cc: @highker

@highker highker merged commit c13f510 into prestodb:master Jun 24, 2022
@highker highker mentioned this pull request Jul 6, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants