Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Reduce Excessive Logging During Setup and Build Process #24455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anandamideShakyan
Copy link
Contributor

Description

The current setup scripts generate excessive output, the goal is to reduce the log output by implementing the following changes:

  1. Avoid printing the files extracted by tar.
  2. Silence the download progress from curl by using an appropriate curl option.
  3. Suppress unnecessary CMake messages, logging only warnings instead of info or status messages.
  4. Introduce a new environment variable to enable the extensive logging when needed.
  5. These changes will help minimize log size while maintaining flexibility for detailed logging when required.

Motivation and Context

The current setup scripts generate excessive log output, which can overwhelm users and make it difficult to identify important information. This excessive logging increases log file sizes unnecessarily, which can be problematic for storage and debugging. By implementing changes to reduce log output, we aim to streamline the logging process, improve readability, and maintain flexibility for detailed logging when required.

Impact

  1. Improved Log Readability: By reducing unnecessary output, users can focus on critical information, making debugging and monitoring more efficient.
  2. Reduced Log Size: Suppressing excessive logging will significantly decrease log file sizes, saving storage space and improving performance.
  3. Flexibility: Introducing an environment variable to enable extensive logging ensures that detailed logs are still available when needed for debugging or analysis.
  4. Enhanced User Experience: A cleaner and more concise logging output will improve the overall user experience, especially for those who do not require verbose logging.

@anandamideShakyan anandamideShakyan requested a review from a team as a code owner January 29, 2025 10:33
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 29, 2025
@prestodb-ci prestodb-ci requested review from a team, infvg and sh-shamsan and removed request for a team January 29, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants