Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for pokefirered-porymap support #1010

Merged
merged 6 commits into from
Apr 29, 2020

Conversation

GriffinRichards
Copy link
Member

@GriffinRichards GriffinRichards commented Mar 27, 2020

NOTE: Do not merge until a version of porymap containing huderlem/porymap#192 is released.
Absorbing #1002 and #1008.

Changes:

  • Map header property names synced with pokefirered. allow_escape_rope --> allow_escaping, and allow_bike --> allow_cycling (b5c56ea)
  • sHealLocations now uses designated initializers, and heal location constants are now allowed to use unique names, so some were updated to remove the vague numbered suffix (6f312da)
  • Some gObjectEventSpriteOamTables names were updated so that they all now use the WxH format (c1ee0e0)
  • Trainer type constants were added (2b0d8ba and 1414f49)
  • Map type constant names were synced with pokefirered (5ac2585)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants