Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use json for region map sections #1651

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Conversation

garakmon
Copy link
Contributor

@garakmon garakmon commented Apr 5, 2022

  • update nlohmann/json and pantor/inja in tools/
  • create new inja template

  - update nlohmann/json and pantor/inja in tools/
  - create new inja template
@rawr51919
Copy link
Contributor

rawr51919 commented Jun 19, 2022

pokeruby companion PR at pret/pokeruby#842
pokefirered companion PR at pret/pokefirered#500

@GriffinRichards
Copy link
Member

GriffinRichards commented Jul 8, 2022

Since you've added a86ae31537bf622367084060fd655db0f403c7f4, do you want to fold in the rest of the changes in #1636? sRegionMap_MapSectionLayout at least should be 2D

EDIT: Reverted

@GriffinRichards GriffinRichards changed the base branch from master to porymap-5 September 26, 2022 01:55
@GriffinRichards GriffinRichards marked this pull request as ready for review September 26, 2022 01:55
@GriffinRichards GriffinRichards merged commit f074464 into pret:porymap-5 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants