Rename special map constants, treat warp ids as strings #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2022
GriffinRichards
force-pushed
the
map-dynamic
branch
from
04e25f6 to
36551df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The following script will automate the changes in this PR
https://gist.github.com/huderlem/b4e342f44093cb40971b36b5aed411c0
This addresses two changes that are breaking changes for Porymap 4.5.0.
MAP_NONEis a special indicator value used exclusively by dynamic warps (warps with more than one potential destination). It's been renamed toMAP_DYNAMIC.MAP_UNDEFINEDcould reasonably take the nameMAP_NONE, but this would be likely to silently break downstream changes."dest_warp_id": ([0-9]+)) and replace ("dest_warp_id": "\1") in Sublime Text.As usual this has been opened as a draft until a version of Porymap is released that supports these changes.