Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build System Rewrite] Massive build speed improvement via scaninc changes #1954

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

Icedude907
Copy link
Contributor

@Icedude907 Icedude907 commented Nov 12, 2023

Description

Works by generating .d files with scaninc, allowing for parallel dependency scanning. This massively improves warm-up time. Building starts almost instantly now.

Benchmarks courtesy of lunos4026 on discord:
Subsequent builds are ~35s faster

Environment: Ubuntu 22.04.3 LTS running on WSL (1).
System: i3 2120, 4GB of RAM (Single Channel, DDR3, 659.4 MHz), Seagate BarraCuda 1TB HDD 7200RPM, Windows 11 22H2 (Build 22621.2283).

Clean Pret/Pokeemerald Master branch:
real    1m55.464s
user    0m28.563s
sys     0m55.313s

2nd `time make -j$(nproc)` pass:
real    0m40.738s
user    0m17.703s
sys     0m11.922s

Icedude907's build-scaninc-speed branch:
real    2m16.833s
user    0m27.234s
sys     0m54.859s

2nd `time make -j$(nproc)` pass:
real    0m4.546s
user    0m0.156s
sys     0m0.719s

Discord contact info

icedude907

Secondary expansion is redundant.
@Icedude907 Icedude907 changed the title [Build System Rewrite] Massive build speed improvement [Build System Rewrite] Massive build speed improvement via scaninc changes Nov 12, 2023
@GriffinRichards GriffinRichards marked this pull request as ready for review August 31, 2024 04:48
@GriffinRichards GriffinRichards merged commit 51131e2 into pret:master Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants