Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX for the aspect ratio of the Pokémon logo on the title screen #2010

Closed
wants to merge 4 commits into from

Conversation

pkmnsnfrn
Copy link
Contributor

Before                                                After

I am pkmnsnfrn on Discord.

@GriffinRichards
Copy link
Member

GriffinRichards commented Aug 7, 2024

This seems to me too subjective a change to include by default, our BUGFIXs should be unambiguous solutions (I'm not even sure I agree this is a bug, but that's beside the point). Anyone who cares about this might care equally about the other minor changes it makes to the appearance, like the highlight inside the "P" disappearing or the changes to the black outline.

@pkmnsnfrn
Copy link
Contributor Author

When I think of BUGFIX I think

the developers did X, but they almost certainly meant to do Y

and I cannot imagine the world's most valuable brand intentionally used the wrong aspect ratio for the logo.

I don't feel that strongly about this feature, and I'm fine if you close it

but

if you agree "yeah, this was probably a mistake" then I can work on fixing the highlight and the black outline and updating this PR.

@GriffinRichards
Copy link
Member

That's a sensible definition of BUGFIX. I don't agree that they almost certainly meant to use the logo in this PR as opposed to the one in-game. I grabbed an official logo online and compared it to the in-game asset; they seem reasonably the same to me:

pokemon_logo

But either way, I think we should avoid including fixes that involve making subjective decisions like for graphic design.

@pkmnsnfrn
Copy link
Contributor Author

That gif is fascinating and very helpful! And I think "no graphic decisions" is more than fair.

cc @meejle

@pkmnsnfrn pkmnsnfrn closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants