Skip to content

Commit

Permalink
Merge pull request #659 from Deokishisu/patch-5
Browse files Browse the repository at this point in the history
BUGFIX for Localization Oversight in Daisy's Text && Fix Typo in Nurse Script
  • Loading branch information
GriffinRichards authored Jun 22, 2024
2 parents 9b2fc69 + b2e2648 commit 4c015cd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions data/maps/PalletTown_RivalsHouse/text.inc
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,13 @@ PalletTown_RivalsHouse_Text_LookingNiceInNoTime::
.string "nice in no time.$"

PalletTown_RivalsHouse_Text_ThereYouGoAllDone::
#ifdef BUGFIX @ The localizers missed what should be a textcolor change in the localizations.
.string "{COLOR DARK_GRAY}{STR_VAR_1} looks dreamily content…\p"
.string "{COLOR RED}DAISY: There you go! All done.\n"
#else @ In the JP games, gender-based text used a different font instead of different colors.
.string "{FONT_NORMAL}{STR_VAR_1} looks dreamily content…\p"
.string "{FONT_FEMALE}DAISY: There you go! All done.\n"
#endif
.string "See? Doesn't it look nice?\p"
.string "Giggle…\n"
.string "It's such a cute POKéMON.$"
Expand Down
4 changes: 2 additions & 2 deletions data/scripts/pkmn_center_nurse.inc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ EventScript_PkmnCenterNurse_CheckTrainerTowerAndUnionRoom::
specialvar VAR_RESULT, BufferUnionRoomPlayerName
copyvar VAR_0x8008, VAR_RESULT
goto_if_eq VAR_0x8008, 0, EventScript_PkmnCenterNurse_ReturnPkmn
goto_if_eq VAR_0x8008, 1, EventScript_PkmnCenterNurse_PlayerWaitingInUionRoom
goto_if_eq VAR_0x8008, 1, EventScript_PkmnCenterNurse_PlayerWaitingInUnionRoom
end

EventScript_PkmnCenterNurse_ReturnPkmn::
Expand All @@ -45,7 +45,7 @@ EventScript_PkmnCenterNurse_ReturnPkmn::
msgbox Text_WeHopeToSeeYouAgain
return

EventScript_PkmnCenterNurse_PlayerWaitingInUionRoom::
EventScript_PkmnCenterNurse_PlayerWaitingInUnionRoom::
goto_if_set FLAG_SYS_INFORMED_OF_LOCAL_WIRELESS_PLAYER, EventScript_PkmnCenterNurse_ReturnPkmn
msgbox Text_RestoredPkmnToFullHealth
setflag FLAG_SYS_INFORMED_OF_LOCAL_WIRELESS_PLAYER
Expand Down

0 comments on commit 4c015cd

Please sign in to comment.